Add host to domain transformation method

New Pull Request

Conversation 0 Commits 1 Files Changed 1

@jonathan please review

jonathan was assigned by kris 4 years ago

kris referenced this pull request from bubblev/bubble 4 years ago

First part of fixing backup-restore test #12

jonathan requested changes 4 years ago

Question about removal of getHost call to validate URI.

src/main/java/org/cobbzilla/util/http/URIUtil.java

												
			@@ -53,4 +61,2 @@
		
			     * @return the "registered" domain, which includes the TLD and one level up.
		
			     */
		
			    public static String getRegisteredDomain(String uri) {
		
			        final String host = getHost(uri);

jonathan commented 4 years ago

The getHost call was used to ensure that the uri argument is a valid URI. Can we leave it in? If that breaks something, maybe use a different method?

kris commented 4 years ago

Nothing is removed. getRegisteredDomain still works as before - redefined in line 56 above, and does call getHost.

hostToDomain is a brand new method with the second part of the previous method required and used currently only in some test.

jonathan commented 4 years ago

Sorry, I missed that. Thanks.

jonathan referenced this issue from a commit 4 years ago

Add host to domain transformation method (#1) Add host to domain transformation method Co-authored-by: Kristijan Mitrovic <kmitrovic@itekako.com> Reviewed-on: https://git.bubblev.org/bubblev/cobbzilla-utils/pulls/1

jonathan closed this pull request 4 years ago

jonathan deleted branch kris/host_to_domain 4 years ago

Reviewers

jonathan requested changes 4 years ago

The pull request has been merged as 45579ec840.

Sign in to join this conversation.

jonathan

No Label

No Milestone

jonathan

2 Participants

Notifications

Due Date

No due date set.

Dependencies

This pull request currently doesn't have any dependencies.

#1 Add host to domain transformation method

Reviewers