Add host to domain transformation method

Nuova Pull Request

Conversazione 0 Commit 1 File modificati 1

@jonathan please review

jonathan è stato assegnato da kris 4 anni fa

kris ha fatto riferimento a questa pull request da bubblev/bubble 4 anni fa

First part of fixing backup-restore test #12

jonathan richieste modifiche 4 anni fa

Question about removal of getHost call to validate URI.

src/main/java/org/cobbzilla/util/http/URIUtil.java

												
			@@ -53,4 +61,2 @@
		
			     * @return the "registered" domain, which includes the TLD and one level up.
		
			     */
		
			    public static String getRegisteredDomain(String uri) {
		
			        final String host = getHost(uri);

jonathan 4 anni fa ha commentato

The getHost call was used to ensure that the uri argument is a valid URI. Can we leave it in? If that breaks something, maybe use a different method?

kris 4 anni fa ha commentato

Nothing is removed. getRegisteredDomain still works as before - redefined in line 56 above, and does call getHost.

hostToDomain is a brand new method with the second part of the previous method required and used currently only in some test.

jonathan 4 anni fa ha commentato

Sorry, I missed that. Thanks.

jonathan ha fatto riferimento a questa issue dal commit 4 anni fa

Add host to domain transformation method (#1) Add host to domain transformation method Co-authored-by: Kristijan Mitrovic <kmitrovic@itekako.com> Reviewed-on: https://git.bubblev.org/bubblev/cobbzilla-utils/pulls/1

jonathan closed this pull request 4 anni fa

jonathan branch kris/host_to_domain eliminato 4 anni fa

Revisori

jonathan richieste modifiche 4 anni fa

La pull request è stata unita come 45579ec840.

Effettua l'accesso per partecipare alla conversazione.

jonathan

Nessuna etichetta

Nessuna milestone

jonathan

2 Partecipanti

Notifiche

Data di scadenza

Nessuna data di scadenza impostata.

Dipendenze

Questo problema attualmente non ha alcuna dipendenza.

#1 Add host to domain transformation method

Revisori