Add host to domain transformation method

Нови захтев за спајање

Дискусија 0 Комити 1 Files Changed 1

@jonathan please review

jonathan was assigned by kris пре 4 година

kris referenced this pull request from bubblev/bubble пре 4 година

First part of fixing backup-restore test #12

jonathan requested changes пре 4 година

Question about removal of getHost call to validate URI.

src/main/java/org/cobbzilla/util/http/URIUtil.java

												
			@@ -53,4 +61,2 @@
		
			     * @return the "registered" domain, which includes the TLD and one level up.
		
			     */
		
			    public static String getRegisteredDomain(String uri) {
		
			        final String host = getHost(uri);

jonathan коментирира пре 4 година

The getHost call was used to ensure that the uri argument is a valid URI. Can we leave it in? If that breaks something, maybe use a different method?

kris коментирира пре 4 година

Nothing is removed. getRegisteredDomain still works as before - redefined in line 56 above, and does call getHost.

hostToDomain is a brand new method with the second part of the previous method required and used currently only in some test.

jonathan коментирира пре 4 година

Sorry, I missed that. Thanks.

jonathan поменуо овај задатак у комит пре 4 година

Add host to domain transformation method (#1) Add host to domain transformation method Co-authored-by: Kristijan Mitrovic <kmitrovic@itekako.com> Reviewed-on: https://git.bubblev.org/bubblev/cobbzilla-utils/pulls/1

jonathan closed this pull request пре 4 година

jonathan deleted branch kris/host_to_domain пре 4 година

Reviewers

jonathan requested changes пре 4 година

The pull request has been merged as 45579ec840.

Пријавите се да се прикључе у овом разговору.

jonathan

Нема лабеле

Нема фазе

jonathan

2 учесника

Notifications

Due Date

No due date set.

Dependencies

This pull request currently doesn't have any dependencies.

#1 Add host to domain transformation method

Reviewers