The getHost call was used to ensure that the uri argument is a valid URI. Can we leave it in? If that breaks something, maybe use a different method?
The `getHost` call was used to ensure that the `uri` argument is a valid URI. Can we leave it in? If that breaks something, maybe use a different method?
Nothing is removed. getRegisteredDomain still works as before - redefined in line 56 above, and does call getHost.
hostToDomain is a brand new method with the second part of the previous method required and used currently only in some test.
Nothing is removed. `getRegisteredDomain` still works as before - redefined in line 56 above, and does call `getHost`.
`hostToDomain` is a brand new method with the second part of the previous method required and used currently only in some test.
jonathan
@jonathan please review
Question about removal of
getHostcall to validate URI.The
getHostcall was used to ensure that theuriargument is a valid URI. Can we leave it in? If that breaks something, maybe use a different method?Nothing is removed.
getRegisteredDomainstill works as before - redefined in line 56 above, and does callgetHost.hostToDomainis a brand new method with the second part of the previous method required and used currently only in some test.Sorry, I missed that. Thanks.
评审人
45579ec840被合并。