Add host to domain transformation method

Uusi pull pyyntö

Keskustelu 0 Commitit 1 Muuttuneet tiedostot 1

@jonathan please review

jonathan was assigned by kris 4 vuotta sitten

kris referenced this pull request from bubblev/bubble 4 vuotta sitten

First part of fixing backup-restore test #12

jonathan requested changes 4 vuotta sitten

Question about removal of getHost call to validate URI.

src/main/java/org/cobbzilla/util/http/URIUtil.java

												
			@@ -53,4 +61,2 @@
		
			     * @return the "registered" domain, which includes the TLD and one level up.
		
			     */
		
			    public static String getRegisteredDomain(String uri) {
		
			        final String host = getHost(uri);

jonathan kommentoi 4 vuotta sitten

The getHost call was used to ensure that the uri argument is a valid URI. Can we leave it in? If that breaks something, maybe use a different method?

kris kommentoi 4 vuotta sitten

Nothing is removed. getRegisteredDomain still works as before - redefined in line 56 above, and does call getHost.

hostToDomain is a brand new method with the second part of the previous method required and used currently only in some test.

jonathan kommentoi 4 vuotta sitten

Sorry, I missed that. Thanks.

jonathan viittasi tähän ongelmaan commitissa 4 vuotta sitten

Add host to domain transformation method (#1) Add host to domain transformation method Co-authored-by: Kristijan Mitrovic <kmitrovic@itekako.com> Reviewed-on: https://git.bubblev.org/bubblev/cobbzilla-utils/pulls/1

jonathan closed this pull request 4 vuotta sitten

jonathan poisti haaran kris/host_to_domain 4 vuotta sitten

Reviewers

jonathan requested changes 4 vuotta sitten

The pull request has been merged as 45579ec840.

Sign in to join this conversation.

jonathan

Ei tunnistetta

Ei merkkipaalua

jonathan

2 osallistujaa

Ilmoitukset

Määräpäivä

Määräpäivää ei asetettu.

Riippuvuudet

Tällä vetopyynnöllä ei tällä hetkellä ole riippuvuuksia.

#1 Add host to domain transformation method

Reviewers