@jonathan please review
Waiting on Jenkins build: https://jenkins.bubblev.org/job/bubble-dev-kris/252/
but not sure how it will go as current master build is failing.
Looks good, but what would the regex be if the intent is “delete any cookies NOT belonging to the current domain, or one of its subdomains”?
It seems like we would need some more logic -- if we add these 2 things I think it would work:
The regex can include {{fqdn}} which will be replaced (in mitm-land) with the (regex-escaped) FQDN for the current request
In addition to regex and replacement, add mode which can be match or no_match. Or, alternatively, see if the “regex negation” syntax works in Python’s regex implementation, see: https://stackoverflow.com/questions/2637675/how-to-negate-the-whole-regex ). If regex negation works, that may be easier.
Thoughts?
Looks good, but what would the regex be if the intent is "delete any cookies NOT belonging to the current domain, or one of its subdomains"?
It seems like we would need some more logic -- if we add these 2 things I think it would work:
1. The regex can include `{{fqdn}}` which will be replaced (in mitm-land) with the (regex-escaped) FQDN for the current request
2. In addition to `regex` and `replacement`, add `mode` which can be `match` or `no_match`. Or, alternatively, see if the "regex negation" syntax works in Python's regex implementation, see: https://stackoverflow.com/questions/2637675/how-to-negate-the-whole-regex ). If regex negation works, that may be easier.
Thoughts?
No, let’s do it in this one. And test it :) this will be very cool when it works!
(?!...) is supported in python3’s re
That’s good news. Let’s do that.
> 1. will do. Separate PR? (easier review)
No, let's do it in this one. And test it :) this will be very cool when it works!
> 2. `(?!...)` is supported in python3's `re`
That's good news. Let's do that.
jonathan
@jonathan please review
Waiting on Jenkins build: https://jenkins.bubblev.org/job/bubble-dev-kris/252/
but not sure how it will go as current master build is failing.
Looks good, but what would the regex be if the intent is “delete any cookies NOT belonging to the current domain, or one of its subdomains”?
It seems like we would need some more logic -- if we add these 2 things I think it would work:
{{fqdn}}which will be replaced (in mitm-land) with the (regex-escaped) FQDN for the current requestregexandreplacement, addmodewhich can bematchorno_match. Or, alternatively, see if the “regex negation” syntax works in Python’s regex implementation, see: https://stackoverflow.com/questions/2637675/how-to-negate-the-whole-regex ). If regex negation works, that may be easier.Thoughts?
(?!...)is supported in python3’sreNo, let’s do it in this one. And test it :) this will be very cool when it works!
That’s good news. Let’s do that.
Add request protector app with cross-domain cookies filtering为 WIP: (testing after fqdn part) Add request protector app with cross-domain cookies filteringWIP: (testing after fqdn part) Add request protector app with cross-domain cookies filtering为 Add request protector app with cross-domain cookies filteringAdd request protector app with cross-domain cookies filtering为 WIP: (waiting on fresh Jenkins build) Add request protector app with cross-domain cookies filteringWIP: (waiting on fresh Jenkins build) Add request protector app with cross-domain cookies filtering为 Add request protector app with cross-domain cookies filteringPassing Jenkins build: https://jenkins.bubblev.org/job/bubble-dev-kris/260/
minor changes requested.
Let’s add
RequestProtectorapp to all plans.r/sligh/slight/Actully, I’ll remove this second part completely as I did a larger changes here recently
评审人
237e90d126被合并。