Add request protector app with cross-domain cookies filtering

Saruna 4 Revīzijas 35 Izmainītie faili 17

@jonathan please review

Waiting on Jenkins build: https://jenkins.bubblev.org/job/bubble-dev-kris/252/
but not sure how it will go as current master build is failing.

jonathan tika piešķirta problēma no kris pirms 4 gadiem

Looks good, but what would the regex be if the intent is “delete any cookies NOT belonging to the current domain, or one of its subdomains”?

It seems like we would need some more logic -- if we add these 2 things I think it would work:

The regex can include {{fqdn}} which will be replaced (in mitm-land) with the (regex-escaped) FQDN for the current request
In addition to regex and replacement, add mode which can be match or no_match. Or, alternatively, see if the “regex negation” syntax works in Python’s regex implementation, see: https://stackoverflow.com/questions/2637675/how-to-negate-the-whole-regex ). If regex negation works, that may be easier.

Thoughts?

will do. Separate PR? (easier review)
(?!...) is supported in python3’s re

will do. Separate PR? (easier review)

No, let’s do it in this one. And test it :) this will be very cool when it works!

(?!...) is supported in python3’s re

That’s good news. Let’s do that.

👍 1

kris nomainīts nosaukums no ~~Add request protector app with cross-domain cookies filtering~~ uz WIP: (testing after fqdn part) Add request protector app with cross-domain cookies filtering pirms 4 gadiem

kris nomainīts nosaukums no ~~WIP: (testing after fqdn part) Add request protector app with cross-domain cookies filtering~~ uz Add request protector app with cross-domain cookies filtering pirms 4 gadiem

kris nomainīts nosaukums no ~~Add request protector app with cross-domain cookies filtering~~ uz WIP: (waiting on fresh Jenkins build) Add request protector app with cross-domain cookies filtering pirms 4 gadiem

kris nomainīts nosaukums no ~~WIP: (waiting on fresh Jenkins build) Add request protector app with cross-domain cookies filtering~~ uz Add request protector app with cross-domain cookies filtering pirms 4 gadiem

Passing Jenkins build: https://jenkins.bubblev.org/job/bubble-dev-kris/260/

jonathan pieprasīja izmaiņas pirms 4 gadiem

minor changes requested.

bubble-server/src/main/resources/models/defaults/bubblePlan.json

												
			@@ -38,2 +38,3 @@
		
			        {"app": "UserBlocker"},
		
			        {"app": "TlsPassthru"}
		
			        {"app": "TlsPassthru"},
		
			        {"app": "RequestProtector"}

jonathan komentēja pirms 4 gadiem

Let’s add RequestProtector app to all plans.

bubble-server/src/main/resources/packer/roles/mitmproxy/files/bubble_api.py

jonathan pieminēja šo problēmu revīzijā pirms 4 gadiem

jonathan aizvēra šo izmaiņu pieprasījumu pirms 4 gadiem

jonathan izdzēsa atzaru kris/request_protector_app pirms 4 gadiem

Recenzenti

jonathan pieprasīja izmaiņas pirms 4 gadiem

Izmaiņu pieprasījums tika sapludināts ar revīziju 237e90d126.

Pierakstieties, lai pievienotos šai sarunai.

jonathan

Nav etiķešu

Nav atskaites punktu

jonathan

2 dalībnieki

Paziņojumi

Izpildes termiņš

Izpildes termiņš nav uzstādīts.

Atkarības

Šim izmaiņu pieprasījumam pagaidām nav nevienas atkarības.

@@ -452,0 +487,4 @@
 def _replace_in_headers(headers: nheaders.Headers, modifiers_dict: dict) -> int:
     """
     Taken from original mitmproxy's Header class implementation with sligh change to allow replacement with empty string

#58 Add request protector app with cross-domain cookies filtering

Recenzenti