Add request protector app with cross-domain cookies filtering

@jonathan please review

Waiting on Jenkins build: https://jenkins.bubblev.org/job/bubble-dev-kris/252/
but not sure how it will go as current master build is failing.

jonathan を kris が担当者に指名 4年前

Looks good, but what would the regex be if the intent is “delete any cookies NOT belonging to the current domain, or one of its subdomains”?

It seems like we would need some more logic -- if we add these 2 things I think it would work:

The regex can include {{fqdn}} which will be replaced (in mitm-land) with the (regex-escaped) FQDN for the current request
In addition to regex and replacement, add mode which can be match or no_match. Or, alternatively, see if the “regex negation” syntax works in Python’s regex implementation, see: https://stackoverflow.com/questions/2637675/how-to-negate-the-whole-regex ). If regex negation works, that may be easier.

Thoughts?

will do. Separate PR? (easier review)
(?!...) is supported in python3’s re

will do. Separate PR? (easier review)

No, let’s do it in this one. And test it :) this will be very cool when it works!

(?!...) is supported in python3’s re

That’s good news. Let’s do that.

👍 1

kris がタイトルを ~~Add request protector app with cross-domain cookies filtering~~ から WIP: (testing after fqdn part) Add request protector app with cross-domain cookies filtering に変更 4年前

kris がタイトルを ~~WIP: (testing after fqdn part) Add request protector app with cross-domain cookies filtering~~ から Add request protector app with cross-domain cookies filtering に変更 4年前

kris がタイトルを ~~Add request protector app with cross-domain cookies filtering~~ から WIP: (waiting on fresh Jenkins build) Add request protector app with cross-domain cookies filtering に変更 4年前

kris がタイトルを ~~WIP: (waiting on fresh Jenkins build) Add request protector app with cross-domain cookies filtering~~ から Add request protector app with cross-domain cookies filtering に変更 4年前

Passing Jenkins build: https://jenkins.bubblev.org/job/bubble-dev-kris/260/

jonathan が変更を要請 4年前

minor changes requested.

bubble-server/src/main/resources/models/defaults/bubblePlan.json

												
			@@ -38,2 +38,3 @@
		
			        {"app": "UserBlocker"},
		
			        {"app": "TlsPassthru"}
		
			        {"app": "TlsPassthru"},
		
			        {"app": "RequestProtector"}

jonathan が 4年前にコメント

Let’s add RequestProtector app to all plans.

bubble-server/src/main/resources/packer/roles/mitmproxy/files/bubble_api.py

jonathan がコミットでこの課題を参照 4年前

jonathan がプルリクエストをクローズ 4年前

jonathan がブランチ kris/request_protector_app を削除 4年前

レビューア

jonathan が変更を要請 4年前

プルリクエストは 237e90d126 でマージされています。

サインインしてこの会話に参加。

jonathan

ラベルなし

マイルストーンなし

jonathan

2 人の参加者

通知

期日

期日は未設定です。

依存関係

このプルリクエストに依存関係はありません。

@@ -452,0 +487,4 @@
 def _replace_in_headers(headers: nheaders.Headers, modifiers_dict: dict) -> int:
     """
     Taken from original mitmproxy's Header class implementation with sligh change to allow replacement with empty string

#58 Add request protector app with cross-domain cookies filtering

レビューア