Add request protector app with cross-domain cookies filtering

Обсуждение 4 Коммиты 35 Измененные файлы 17

@jonathan please review

Waiting on Jenkins build: https://jenkins.bubblev.org/job/bubble-dev-kris/252/
but not sure how it will go as current master build is failing.

jonathan был назначен kris 4 лет назад

Looks good, but what would the regex be if the intent is “delete any cookies NOT belonging to the current domain, or one of its subdomains”?

It seems like we would need some more logic -- if we add these 2 things I think it would work:

The regex can include {{fqdn}} which will be replaced (in mitm-land) with the (regex-escaped) FQDN for the current request
In addition to regex and replacement, add mode which can be match or no_match. Or, alternatively, see if the “regex negation” syntax works in Python’s regex implementation, see: https://stackoverflow.com/questions/2637675/how-to-negate-the-whole-regex ). If regex negation works, that may be easier.

Thoughts?

will do. Separate PR? (easier review)
(?!...) is supported in python3’s re

will do. Separate PR? (easier review)

No, let’s do it in this one. And test it :) this will be very cool when it works!

(?!...) is supported in python3’s re

That’s good news. Let’s do that.

👍 1

kris изменил заголовок с ~~Add request protector app with cross-domain cookies filtering~~ на WIP: (testing after fqdn part) Add request protector app with cross-domain cookies filtering 4 лет назад

kris изменил заголовок с ~~WIP: (testing after fqdn part) Add request protector app with cross-domain cookies filtering~~ на Add request protector app with cross-domain cookies filtering 4 лет назад

kris изменил заголовок с ~~Add request protector app with cross-domain cookies filtering~~ на WIP: (waiting on fresh Jenkins build) Add request protector app with cross-domain cookies filtering 4 лет назад

kris изменил заголовок с ~~WIP: (waiting on fresh Jenkins build) Add request protector app with cross-domain cookies filtering~~ на Add request protector app with cross-domain cookies filtering 4 лет назад

Passing Jenkins build: https://jenkins.bubblev.org/job/bubble-dev-kris/260/

jonathan запросил(а) изменения 4 лет назад

minor changes requested.

bubble-server/src/main/resources/models/defaults/bubblePlan.json

												
			@@ -38,2 +38,3 @@
		
			        {"app": "UserBlocker"},
		
			        {"app": "TlsPassthru"}
		
			        {"app": "TlsPassthru"},
		
			        {"app": "RequestProtector"}

jonathan прокомментировал 4 лет назад

Let’s add RequestProtector app to all plans.

bubble-server/src/main/resources/packer/roles/mitmproxy/files/bubble_api.py

jonathan упомянул эту задачу в коммите 4 лет назад

jonathan closed this pull request 4 лет назад

jonathan удалена ветка kris/request_protector_app 4 лет назад

Рецензенты

jonathan запросил(а) изменения 4 лет назад

Pull Request был объединен как %!с(string=237e90d126).

Войдите, чтобы присоединиться к обсуждению.

jonathan

Нет меток

Нет этапа

jonathan

2 участников

Уведомления

Срок выполнения

Срок выполнения не установлен.

Зависимости

Этот запрос на слияние в настоящее время не имеет никаких зависимостей.

@@ -452,0 +487,4 @@
 def _replace_in_headers(headers: nheaders.Headers, modifiers_dict: dict) -> int:
     """
     Taken from original mitmproxy's Header class implementation with sligh change to allow replacement with empty string

#58 Add request protector app with cross-domain cookies filtering

Рецензенты