Add request protector app with cross-domain cookies filtering

Conversazione 4 Commit 35 File modificati 17

@jonathan please review

Waiting on Jenkins build: https://jenkins.bubblev.org/job/bubble-dev-kris/252/
but not sure how it will go as current master build is failing.

jonathan è stato assegnato da kris 4 anni fa

Looks good, but what would the regex be if the intent is “delete any cookies NOT belonging to the current domain, or one of its subdomains”?

It seems like we would need some more logic -- if we add these 2 things I think it would work:

The regex can include {{fqdn}} which will be replaced (in mitm-land) with the (regex-escaped) FQDN for the current request
In addition to regex and replacement, add mode which can be match or no_match. Or, alternatively, see if the “regex negation” syntax works in Python’s regex implementation, see: https://stackoverflow.com/questions/2637675/how-to-negate-the-whole-regex ). If regex negation works, that may be easier.

Thoughts?

will do. Separate PR? (easier review)
(?!...) is supported in python3’s re

will do. Separate PR? (easier review)

No, let’s do it in this one. And test it :) this will be very cool when it works!

(?!...) is supported in python3’s re

That’s good news. Let’s do that.

👍 1

kris Titolo modificato da ~~Add request protector app with cross-domain cookies filtering~~ a WIP: (testing after fqdn part) Add request protector app with cross-domain cookies filtering 4 anni fa

kris Titolo modificato da ~~WIP: (testing after fqdn part) Add request protector app with cross-domain cookies filtering~~ a Add request protector app with cross-domain cookies filtering 4 anni fa

kris Titolo modificato da ~~Add request protector app with cross-domain cookies filtering~~ a WIP: (waiting on fresh Jenkins build) Add request protector app with cross-domain cookies filtering 4 anni fa

kris Titolo modificato da ~~WIP: (waiting on fresh Jenkins build) Add request protector app with cross-domain cookies filtering~~ a Add request protector app with cross-domain cookies filtering 4 anni fa

Passing Jenkins build: https://jenkins.bubblev.org/job/bubble-dev-kris/260/

jonathan richieste modifiche 4 anni fa

minor changes requested.

bubble-server/src/main/resources/models/defaults/bubblePlan.json

												
			@@ -38,2 +38,3 @@
		
			        {"app": "UserBlocker"},
		
			        {"app": "TlsPassthru"}
		
			        {"app": "TlsPassthru"},
		
			        {"app": "RequestProtector"}

jonathan 4 anni fa ha commentato

Let’s add RequestProtector app to all plans.

bubble-server/src/main/resources/packer/roles/mitmproxy/files/bubble_api.py

jonathan ha fatto riferimento a questa issue dal commit 4 anni fa

jonathan closed this pull request 4 anni fa

jonathan branch kris/request_protector_app eliminato 4 anni fa

Revisori

jonathan richieste modifiche 4 anni fa

La pull request è stata unita come 237e90d126.

Effettua l'accesso per partecipare alla conversazione.

jonathan

Nessuna etichetta

Nessuna milestone

jonathan

2 Partecipanti

Notifiche

Data di scadenza

Nessuna data di scadenza impostata.

Dipendenze

Questo problema attualmente non ha alcuna dipendenza.

@@ -452,0 +487,4 @@
 def _replace_in_headers(headers: nheaders.Headers, modifiers_dict: dict) -> int:
     """
     Taken from original mitmproxy's Header class implementation with sligh change to allow replacement with empty string

#58 Add request protector app with cross-domain cookies filtering

Revisori