Add UI needed for restore bubble process

New Pull Request

Conversation 2 Commits 40 Files Changed 10

There is no content yet.

kris changed title from ~~WIP: (testing) Add UI needed for restore bubble process~~ to WIP: (testing & blocked by https://git.bubblev.org/bubblev/bubble/pulls/20 ) Add UI needed for restore bubble process 4 years ago

jonathan requested changes 4 years ago

Looks good to me. Would have to try it to tell you more.

please also resolve merge conflict. thanks.

kris changed title from ~~WIP: (testing & blocked by https://git.bubblev.org/bubblev/bubble/pulls/20 ) Add UI needed for restore bubble process~~ to Add UI needed for restore bubble process 4 years ago

@kris can you please resolve merge conflicts? I changed some stuff with how stop/delete bubble works.

jonathan requested changes 4 years ago

Looks great. Just a couple of questions/comments.

src/_store/system.module.js

src/auth/RestorePage.vue

												
			@@ -0,0 +34,4 @@
		
			                    <div v-if="submitted && errors.has('restoreLongNetworkKey')" class="invalid-feedback d-block">
		
			                        {{ errors.first('restoreLongNetworkKey') }}
		
			                    </div>
		
			                </div>

jonathan commented 4 years ago

Can we do this as a file-upload instead? We should make also sure that the downloaded restore key has a .txt file extension in any case; please confirm.

kris commented 4 years ago

Sure, but can we do this in another PR?
It would be also good to download this key as txt file at the first place in bubble’s page on the node itself (which is why we need that bubble page there - I see you removed that comment, so I guess you tried it).

I’ll be implementing this today (if merging master and retesting goes ok), but in separate branch starting from this one.

jonathan commented 4 years ago

Sure, we can do the file upload in another PR.

jonathan referenced this issue from a commit 4 years ago

jonathan closed this pull request 4 years ago

jonathan deleted branch kris/add_restore_ui 4 years ago

Reviewers

jonathan requested changes 4 years ago

The pull request has been merged as 142ac2090a.

Sign in to join this conversation.

jonathan

No Label

No Milestone

No Assignees

2 Participants

Notifications

Due Date

No due date set.

Dependencies

This pull request currently doesn't have any dependencies.

@@ -180,0 +183,4 @@
                 title: messages.label_menu_network,
                 icon: messages.label_menu_networks_icon,
                 index: 1
             });

#8 Add UI needed for restore bubble process

Reviewers