bubblev
/
bubble-web
8
0
Derivar 0
Código Questões 0 Pedidos de integração 0 Lançamentos 0 Wiki Trabalho
Etiquetas Etapas
Novo pedido de integração

#8 Add UI needed for restore bubble process

Integração executada
jonathan integrou 40 cometimentos de %!<(string=kris/add_restore_ui)/code> em master há 4 anos
Diálogo 2 Cometimentos 40 Ficheiros modificados 10
kris comentado há 4 anos
Ainda não há conteúdo.
kris mudou o título de WIP: (testing) Add UI needed for restore bubble process para WIP: (testing & blocked by https://git.bubblev.org/bubblev/bubble/pulls/20 ) Add UI needed for restore bubble process há 4 anos
jonathan alterações solicitadas há 4 anos
jonathan deixou um comentário

Looks good to me. Would have to try it to tell you more.

jonathan comentado há 4 anos
Proprietário(a)

please also resolve merge conflict. thanks.

please also resolve merge conflict. thanks.
kris mudou o título de WIP: (testing & blocked by https://git.bubblev.org/bubblev/bubble/pulls/20 ) Add UI needed for restore bubble process para Add UI needed for restore bubble process há 4 anos
jonathan comentado há 4 anos
Proprietário(a)

@kris can you please resolve merge conflicts? I changed some stuff with how stop/delete bubble works.

@kris can you please resolve merge conflicts? I changed some stuff with how stop/delete bubble works.
jonathan alterações solicitadas há 4 anos
jonathan deixou um comentário

Looks great. Just a couple of questions/comments.

src/_store/system.module.js
@@ -180,0 +183,4 @@
title: messages.label_menu_network,
icon: messages.label_menu_networks_icon,
index: 1
});
jonathan comentado há 4 anos

I think this should only be added if isAdmin is true, right?

I think this should only be added if `isAdmin` is true, right?
kris comentado há 4 anos

Yeap, I’ll add that check.

Yeap, I'll add that check.
src/auth/RestorePage.vue
@@ -0,0 +34,4 @@
<div v-if="submitted && errors.has('restoreLongNetworkKey')" class="invalid-feedback d-block">
{{ errors.first('restoreLongNetworkKey') }}
</div>
</div>
jonathan comentado há 4 anos

Can we do this as a file-upload instead? We should make also sure that the downloaded restore key has a .txt file extension in any case; please confirm.

Can we do this as a file-upload instead? We should make also sure that the downloaded restore key has a `.txt` file extension in any case; please confirm.
kris comentado há 4 anos

Sure, but can we do this in another PR?
It would be also good to download this key as txt file at the first place in bubble’s page on the node itself (which is why we need that bubble page there - I see you removed that comment, so I guess you tried it).

I’ll be implementing this today (if merging master and retesting goes ok), but in separate branch starting from this one.

Sure, but can we do this in another PR? It would be also good to download this key as txt file at the first place in bubble's page on the node itself (which is why we need that bubble page there - I see you removed that comment, so I guess you tried it). I'll be implementing this today (if merging master and retesting goes ok), but in separate branch starting from this one.
jonathan comentado há 4 anos

Sure, we can do the file upload in another PR.

Sure, we can do the file upload in another PR.
jonathan referenciou esta questão num cometimento há 4 anos
Add UI needed for restore bubble process (#8) Remove not used property from parameter object Show bubble menu item only to admins on nodes Merge branch 'master' into kris/add_restore_ui # Conflicts: # src/account/NetworkPage.vue Reference method properly within this Merge branch 'master' into kris/add_restore_ui # Conflicts: # src/account/NetworkPage.vue Show link properly for network in restoring state Load backups only when needed for netwrok in restoring state Link for restoring node Use latest stats for network Merge branch 'master' into kris/add_restore_ui Fix loading image for backups label Call backups API only once while starting network Show backup info in proper places only Show latest backup and allow queuing new one Use proper name for waiting restoring flag Merge branch 'master' into kris/add_restore_ui Add support for stopping metworks in restoring state Merge branch 'master' into kris/add_restore_ui # Conflicts: # src/_store/system.module.js # src/account/NetworkPage.vue Use dinamyc labels-messages Report restore is started on the page Redirect to restore page in restoring mode Fix indent Split page for restore from login page Merge branch 'master' into kris/add_restore_ui Merge branch 'master' into kris/add_restore_ui Merge branch 'master' into kris/add_restore_ui Merge branch 'master' into kris/add_restore_ui Merge branch 'master' into kris/add_restore_ui # Conflicts: # src/_store/system.module.js # src/account/NetworksPage.vue # src/auth/LoginPage.vue Merge branch 'master' into kris/add_restore_ui Merge branch 'master' into kris/add_restore_ui Merge branch 'master' into kris/add_restore_ui # Conflicts: # src/auth/LoginPage.vue Merge branch 'master' into kris/add_restore_ui # Conflicts: # src/_services/user.service.js Reference configs properly through this object Add support for restoring bubble on running instance Show restore short key to user Enhance Danger Zone on UI Add restore network UI elements Redirect to single bubble page on non-sage networks Remove setup help message on the node itself Add bubble info page on end bubble server's WebUI Co-authored-by: Kristijan Mitrovic <kmitrovic@itekako.com> Reviewed-on: https://git.bubblev.org/bubblev/bubble-web/pulls/8
jonathan fechou este pedido de integração há 4 anos
jonathan eliminou o ramo kris/add_restore_ui há 4 anos

Revisores

jonathan alterações solicitadas há 4 anos
A integração constante no pedido foi executada como 142ac2090a.
Inicie a sessão para participar neste diálogo.
Revisores
Solicitar avaliação
Sem revisores
 jonathan
Etiquetas
Aplicar etiquetas
Limpar etiquetas
Sem itens
Sem etiquetas
Etapa
Definir etapa
Limpar etapa
Sem itens
Sem etapa
Responsáveis
Definir responsáveis
Limpar responsáveis
Sem responsáveis
2 Participantes
Notificações
Date limite

Sem data limite definida.

Dependências

Este pedido de integração não tem quaisquer dependências, neste momento.

Escrever Pré-visualizar
Carregando…
Cancelar
Guardar
Ainda não há conteúdo.
Eliminar o ramo 'kris/add_restore_ui'

Eliminar um ramo é algo permanente. NÃO PODERÁ ser revertido. Quer continuar?

Não
Sim