kris
başlık WIP: (testing) Add UI needed for restore bubble process iken WIP: (testing & blocked by https://git.bubblev.org/bubblev/bubble/pulls/20 ) Add UI needed for restore bubble process olarak değiştirildi 4 yıl önce
kris
başlık WIP: (testing & blocked by https://git.bubblev.org/bubblev/bubble/pulls/20 ) Add UI needed for restore bubble process iken Add UI needed for restore bubble process olarak değiştirildi 4 yıl önce
Can we do this as a file-upload instead? We should make also sure that the downloaded restore key has a .txt file extension in any case; please confirm.
Can we do this as a file-upload instead? We should make also sure that the downloaded restore key has a `.txt` file extension in any case; please confirm.
Sure, but can we do this in another PR?
It would be also good to download this key as txt file at the first place in bubble’s page on the node itself (which is why we need that bubble page there - I see you removed that comment, so I guess you tried it).
I’ll be implementing this today (if merging master and retesting goes ok), but in separate branch starting from this one.
Sure, but can we do this in another PR?
It would be also good to download this key as txt file at the first place in bubble's page on the node itself (which is why we need that bubble page there - I see you removed that comment, so I guess you tried it).
I'll be implementing this today (if merging master and retesting goes ok), but in separate branch starting from this one.
WIP: (testing) Add UI needed for restore bubble processiken WIP: (testing & blocked by https://git.bubblev.org/bubblev/bubble/pulls/20 ) Add UI needed for restore bubble process olarak değiştirildi 4 yıl önceLooks good to me. Would have to try it to tell you more.
please also resolve merge conflict. thanks.
WIP: (testing & blocked by https://git.bubblev.org/bubblev/bubble/pulls/20 ) Add UI needed for restore bubble processiken Add UI needed for restore bubble process olarak değiştirildi 4 yıl önce@kris can you please resolve merge conflicts? I changed some stuff with how stop/delete bubble works.
Looks great. Just a couple of questions/comments.
I think this should only be added if
isAdmin
is true, right?Yeap, I’ll add that check.
Can we do this as a file-upload instead? We should make also sure that the downloaded restore key has a
.txt
file extension in any case; please confirm.Sure, but can we do this in another PR?
It would be also good to download this key as txt file at the first place in bubble’s page on the node itself (which is why we need that bubble page there - I see you removed that comment, so I guess you tried it).
I’ll be implementing this today (if merging master and retesting goes ok), but in separate branch starting from this one.
Sure, we can do the file upload in another PR.
Gözden Geçirenler
142ac2090a
olarak birleştirildi.