bubblev
/
bubble-web
8
0
Fork 0
Código Issues 0 Pull requests 0 Versões 0 Wiki Atividade
Etiquetas Marcos
Novo pull request

#8 Add UI needed for restore bubble process

Merge aplicado
jonathan aplicou merge dos 40 commits de kris/add_restore_ui em master 4 anos atrás
Conversação 2 Commits 40 Arquivos alterados 10
kris comentou 4 anos atrás
Ainda não há conteúdo.
kris alterou o título de WIP: (testing) Add UI needed for restore bubble process para WIP: (testing & blocked by https://git.bubblev.org/bubblev/bubble/pulls/20 ) Add UI needed for restore bubble process 4 anos atrás
jonathan alterações solicitadas 4 anos atrás
jonathan left a comment

Looks good to me. Would have to try it to tell you more.

jonathan comentou 4 anos atrás
Proprietário

please also resolve merge conflict. thanks.

please also resolve merge conflict. thanks.
kris alterou o título de WIP: (testing & blocked by https://git.bubblev.org/bubblev/bubble/pulls/20 ) Add UI needed for restore bubble process para Add UI needed for restore bubble process 4 anos atrás
jonathan comentou 4 anos atrás
Proprietário

@kris can you please resolve merge conflicts? I changed some stuff with how stop/delete bubble works.

@kris can you please resolve merge conflicts? I changed some stuff with how stop/delete bubble works.
jonathan alterações solicitadas 4 anos atrás
jonathan left a comment

Looks great. Just a couple of questions/comments.

src/_store/system.module.js
@@ -180,0 +183,4 @@
title: messages.label_menu_network,
icon: messages.label_menu_networks_icon,
index: 1
});
jonathan comentou 4 anos atrás

I think this should only be added if isAdmin is true, right?

I think this should only be added if `isAdmin` is true, right?
kris comentou 4 anos atrás

Yeap, I’ll add that check.

Yeap, I'll add that check.
src/auth/RestorePage.vue
@@ -0,0 +34,4 @@
<div v-if="submitted && errors.has('restoreLongNetworkKey')" class="invalid-feedback d-block">
{{ errors.first('restoreLongNetworkKey') }}
</div>
</div>
jonathan comentou 4 anos atrás

Can we do this as a file-upload instead? We should make also sure that the downloaded restore key has a .txt file extension in any case; please confirm.

Can we do this as a file-upload instead? We should make also sure that the downloaded restore key has a `.txt` file extension in any case; please confirm.
kris comentou 4 anos atrás

Sure, but can we do this in another PR?
It would be also good to download this key as txt file at the first place in bubble’s page on the node itself (which is why we need that bubble page there - I see you removed that comment, so I guess you tried it).

I’ll be implementing this today (if merging master and retesting goes ok), but in separate branch starting from this one.

Sure, but can we do this in another PR? It would be also good to download this key as txt file at the first place in bubble's page on the node itself (which is why we need that bubble page there - I see you removed that comment, so I guess you tried it). I'll be implementing this today (if merging master and retesting goes ok), but in separate branch starting from this one.
jonathan comentou 4 anos atrás

Sure, we can do the file upload in another PR.

Sure, we can do the file upload in another PR.
jonathan citou esta issue em um commit 4 anos atrás
Add UI needed for restore bubble process (#8) Remove not used property from parameter object Show bubble menu item only to admins on nodes Merge branch 'master' into kris/add_restore_ui # Conflicts: # src/account/NetworkPage.vue Reference method properly within this Merge branch 'master' into kris/add_restore_ui # Conflicts: # src/account/NetworkPage.vue Show link properly for network in restoring state Load backups only when needed for netwrok in restoring state Link for restoring node Use latest stats for network Merge branch 'master' into kris/add_restore_ui Fix loading image for backups label Call backups API only once while starting network Show backup info in proper places only Show latest backup and allow queuing new one Use proper name for waiting restoring flag Merge branch 'master' into kris/add_restore_ui Add support for stopping metworks in restoring state Merge branch 'master' into kris/add_restore_ui # Conflicts: # src/_store/system.module.js # src/account/NetworkPage.vue Use dinamyc labels-messages Report restore is started on the page Redirect to restore page in restoring mode Fix indent Split page for restore from login page Merge branch 'master' into kris/add_restore_ui Merge branch 'master' into kris/add_restore_ui Merge branch 'master' into kris/add_restore_ui Merge branch 'master' into kris/add_restore_ui Merge branch 'master' into kris/add_restore_ui # Conflicts: # src/_store/system.module.js # src/account/NetworksPage.vue # src/auth/LoginPage.vue Merge branch 'master' into kris/add_restore_ui Merge branch 'master' into kris/add_restore_ui Merge branch 'master' into kris/add_restore_ui # Conflicts: # src/auth/LoginPage.vue Merge branch 'master' into kris/add_restore_ui # Conflicts: # src/_services/user.service.js Reference configs properly through this object Add support for restoring bubble on running instance Show restore short key to user Enhance Danger Zone on UI Add restore network UI elements Redirect to single bubble page on non-sage networks Remove setup help message on the node itself Add bubble info page on end bubble server's WebUI Co-authored-by: Kristijan Mitrovic <kmitrovic@itekako.com> Reviewed-on: https://git.bubblev.org/bubblev/bubble-web/pulls/8
jonathan closed this pull request 4 anos atrás
jonathan excluiu branch kris/add_restore_ui 4 anos atrás

Revisores

jonathan alterações solicitadas 4 anos atrás
O pull request teve merge aplicado como 142ac2090a.
Acesse para participar desta conversação.
Revisores
Request review
No reviewers
 jonathan
Etiquetas
Apply labels
Limpar etiquetas
No items
Sem etiqueta
Marco
Set milestone
Limpar marco
No items
Sem marco
Responsáveis
Assign users
Limpar responsáveis
Sem responsável
2 participante(s)
Notificações
Data limite

Data limite não informada.

Dependências

Atualmente este pull request não tem dependências.

Escrever Pré-visualização
Carregando…
Cancelar
Salvar
Ainda não há conteúdo.
Excluir branch 'kris/add_restore_ui'

A exclusão de uma branch é permanente. Isto NÃO PODERÁ ser desfeito. Continuar?

Não
Sim