Add UI needed for restore bubble process

Saruna 2 Revīzijas 40 Izmainītie faili 10

Vēl nav satura.

kris nomainīts nosaukums no ~~WIP: (testing) Add UI needed for restore bubble process~~ uz WIP: (testing & blocked by https://git.bubblev.org/bubblev/bubble/pulls/20 ) Add UI needed for restore bubble process pirms 4 gadiem

jonathan pieprasīja izmaiņas pirms 4 gadiem

Looks good to me. Would have to try it to tell you more.

please also resolve merge conflict. thanks.

kris nomainīts nosaukums no ~~WIP: (testing & blocked by https://git.bubblev.org/bubblev/bubble/pulls/20 ) Add UI needed for restore bubble process~~ uz Add UI needed for restore bubble process pirms 4 gadiem

@kris can you please resolve merge conflicts? I changed some stuff with how stop/delete bubble works.

jonathan pieprasīja izmaiņas pirms 4 gadiem

Looks great. Just a couple of questions/comments.

src/_store/system.module.js

src/auth/RestorePage.vue

												
			@@ -0,0 +34,4 @@
		
			                    <div v-if="submitted && errors.has('restoreLongNetworkKey')" class="invalid-feedback d-block">
		
			                        {{ errors.first('restoreLongNetworkKey') }}
		
			                    </div>
		
			                </div>

jonathan komentēja pirms 4 gadiem

Can we do this as a file-upload instead? We should make also sure that the downloaded restore key has a .txt file extension in any case; please confirm.

kris komentēja pirms 4 gadiem

Sure, but can we do this in another PR?
It would be also good to download this key as txt file at the first place in bubble’s page on the node itself (which is why we need that bubble page there - I see you removed that comment, so I guess you tried it).

I’ll be implementing this today (if merging master and retesting goes ok), but in separate branch starting from this one.

jonathan komentēja pirms 4 gadiem

Sure, we can do the file upload in another PR.

jonathan pieminēja šo problēmu revīzijā pirms 4 gadiem

jonathan aizvēra šo izmaiņu pieprasījumu pirms 4 gadiem

jonathan izdzēsa atzaru kris/add_restore_ui pirms 4 gadiem

Recenzenti

jonathan pieprasīja izmaiņas pirms 4 gadiem

Izmaiņu pieprasījums tika sapludināts ar revīziju 142ac2090a.

Pierakstieties, lai pievienotos šai sarunai.

jonathan

Nav etiķešu

Nav atskaites punktu

Nav atbildīgo

2 dalībnieki

Paziņojumi

Izpildes termiņš

Izpildes termiņš nav uzstādīts.

Atkarības

Šim izmaiņu pieprasījumam pagaidām nav nevienas atkarības.

@@ -180,0 +183,4 @@
                 title: messages.label_menu_network,
                 icon: messages.label_menu_networks_icon,
                 index: 1
             });

#8 Add UI needed for restore bubble process

Recenzenti