Het verwijderen van een branch is permanent. Het KAN NIET ongedaan gemaakt worden. Wil je toch doorgaan?
kris/refactor_redis_service
naar master
4 jaren geleden
Het verwijderen van een branch is permanent. Het KAN NIET ongedaan gemaakt worden. Wil je toch doorgaan?
WIP: (testing) Cleaning redis servicenaar Cleaning redis service adn adding ttl getter method 4 jaren geleden@jonathan please review
Cleaning redis service adn adding ttl getter methodnaar Cleaning redis service and adding ttl getter method 4 jaren geleden@kris -- Things that make me wary:
var
in a low-level library. The lower you go, the more explicit types should be. Why introduce another potential source of errors? Can we removevar
and replace with class names?Please give me a heads-up in advance before refactoring more library code. With the above changes I will merge this, but frankly I don’t see a big benefit given the risk. If we had more comprehensive test coverage I would feel better about the risk.
prefix(Collection<String>)
. In master (current version) following is usedtransform(keys, o -> prefix(o.toString()))
- so lambda is there also. I did some perfomance test on this, and the new solution worked 2x faster at least on collections with 10.000 Strings. Please confirm you really want apache’s transform method back. Or maybe to just change all this and use plain for loop with another collection created as output?5d199cbd98
.