#11 Cleaning redis service and adding ttl getter method

マージ済み
jonathan が 4 個のコミットを kris/refactor_redis_service から master へマージ 4年前
kris4年前 にコメント
まだ内容がありません
kris がタイトルを WIP: (testing) Cleaning redis service から Cleaning redis service adn adding ttl getter method に変更 4年前
kris4年前 にコメント
投稿者

@jonathan please review

@jonathan please review
jonathankris が担当者に指名 4年前
kris がタイトルを Cleaning redis service adn adding ttl getter method から Cleaning redis service and adding ttl getter method に変更 4年前
jonathan4年前 にコメント
オーナー

@kris -- Things that make me wary:

  • use of var in a low-level library. The lower you go, the more explicit types should be. Why introduce another potential source of errors? Can we remove var and replace with class names?
  • use of streams/lambdas/collecting and in general anywhere we are now creating new objects when we could have avoided it. low level libraries should generally prefer for-loops and static classes. Can you review and avoid using stream methods and allocating new objects where possible?

Please give me a heads-up in advance before refactoring more library code. With the above changes I will merge this, but frankly I don’t see a big benefit given the risk. If we had more comprehensive test coverage I would feel better about the risk.

@kris -- Things that make me wary: * use of `var` in a low-level library. The lower you go, the more explicit types should be. Why introduce another potential source of errors? Can we remove `var` and replace with class names? * use of streams/lambdas/collecting and in general anywhere we are now creating new objects when we could have avoided it. low level libraries should generally prefer for-loops and static classes. Can you review and avoid using stream methods and allocating new objects where possible? Please give me a heads-up in advance before refactoring more library code. With the above changes I will merge this, but frankly I don't see a big benefit given the risk. If we had more comprehensive test coverage I would feel better about the risk.
kris4年前 にコメント
投稿者
  • Removing var (only String was replaced in 5ish places, so it was easy) - agree, sorry
  • stream/lambda/collect is used just in 1 place - method prefix(Collection<String>). In master (current version) following is used transform(keys, o -> prefix(o.toString())) - so lambda is there also. I did some perfomance test on this, and the new solution worked 2x faster at least on collections with 10.000 Strings. Please confirm you really want apache’s transform method back. Or maybe to just change all this and use plain for loop with another collection created as output?
- Removing var (only String was replaced in 5ish places, so it was easy) - agree, sorry - stream/lambda/collect is used just in 1 place - method `prefix(Collection<String>)`. In master (current version) following is used `transform(keys, o -> prefix(o.toString()))` - so lambda is there also. I did some perfomance test on this, and the new solution worked 2x faster at least on collections with 10.000 Strings. Please confirm you really want apache's transform method back. Or maybe to just change all this and use plain for loop with another collection created as output?
jonathan がプルリクエストをクローズ 4年前
jonathan がブランチ kris/refactor_redis_service を削除 4年前
プルリクエストは 5d199cbd98 でマージされています。
サインインしてこの会話に参加。
レビューアなし
ラベルなし
マイルストーンなし
担当者なし
2 人の参加者
通知
期日

期日は未設定です。

依存関係

このプルリクエストに依存関係はありません。

読み込み中…
まだ内容がありません