#11 Cleaning redis service and adding ttl getter method

Yhdistetty
jonathan yhdistetty 4 committia lähteestä kris/refactor_redis_service kohteeseen master 4 vuotta sitten
kris kommentoi 4 vuotta sitten
Sisältöä ei vielä ole.
kris changed title from WIP: (testing) Cleaning redis service to Cleaning redis service adn adding ttl getter method 4 vuotta sitten
kris kommentoi 4 vuotta sitten
Tekijä

@jonathan please review

@jonathan please review
jonathan was assigned by kris 4 vuotta sitten
kris changed title from Cleaning redis service adn adding ttl getter method to Cleaning redis service and adding ttl getter method 4 vuotta sitten
jonathan kommentoi 4 vuotta sitten
Omistaja

@kris -- Things that make me wary:

  • use of var in a low-level library. The lower you go, the more explicit types should be. Why introduce another potential source of errors? Can we remove var and replace with class names?
  • use of streams/lambdas/collecting and in general anywhere we are now creating new objects when we could have avoided it. low level libraries should generally prefer for-loops and static classes. Can you review and avoid using stream methods and allocating new objects where possible?

Please give me a heads-up in advance before refactoring more library code. With the above changes I will merge this, but frankly I don’t see a big benefit given the risk. If we had more comprehensive test coverage I would feel better about the risk.

@kris -- Things that make me wary: * use of `var` in a low-level library. The lower you go, the more explicit types should be. Why introduce another potential source of errors? Can we remove `var` and replace with class names? * use of streams/lambdas/collecting and in general anywhere we are now creating new objects when we could have avoided it. low level libraries should generally prefer for-loops and static classes. Can you review and avoid using stream methods and allocating new objects where possible? Please give me a heads-up in advance before refactoring more library code. With the above changes I will merge this, but frankly I don't see a big benefit given the risk. If we had more comprehensive test coverage I would feel better about the risk.
kris kommentoi 4 vuotta sitten
Tekijä
  • Removing var (only String was replaced in 5ish places, so it was easy) - agree, sorry
  • stream/lambda/collect is used just in 1 place - method prefix(Collection<String>). In master (current version) following is used transform(keys, o -> prefix(o.toString())) - so lambda is there also. I did some perfomance test on this, and the new solution worked 2x faster at least on collections with 10.000 Strings. Please confirm you really want apache’s transform method back. Or maybe to just change all this and use plain for loop with another collection created as output?
- Removing var (only String was replaced in 5ish places, so it was easy) - agree, sorry - stream/lambda/collect is used just in 1 place - method `prefix(Collection<String>)`. In master (current version) following is used `transform(keys, o -> prefix(o.toString()))` - so lambda is there also. I did some perfomance test on this, and the new solution worked 2x faster at least on collections with 10.000 Strings. Please confirm you really want apache's transform method back. Or maybe to just change all this and use plain for loop with another collection created as output?
jonathan closed this pull request 4 vuotta sitten
jonathan poisti haaran kris/refactor_redis_service 4 vuotta sitten
The pull request has been merged as 5d199cbd98.
Sign in to join this conversation.
No reviewers
Ei tunnistetta
Ei merkkipaalua
Ei käsittelijää
2 osallistujaa
Ilmoitukset
Määräpäivä

Määräpäivää ei asetettu.

Riippuvuudet

Tällä vetopyynnöllä ei tällä hetkellä ole riippuvuuksia.

Ladataan…
Sisältöä ei vielä ole.