#12 Refactor bulk delete method

Спојено
jonathan споји(ла) 8 комит(е) из kris/refactor_bulk_delete_methods у master пре 4 година
kris коментирира пре 4 година

@jonathan please review

@jonathan please review
jonathan was assigned by kris пре 4 година
jonathan requested changes пре 4 година
jonathan left a comment

a couple changes requested

@@ -361,3 +355,3 @@
return bulkDeleteWhere(condition, params);
}

public int bulkDeleteWhere(String whereClause) {
jonathan коментирира пре 4 година

We still need the version of bulkDeleteWhere that just takes a String and no parameters Map

We still need the version of `bulkDeleteWhere` that just takes a String and no `parameters` Map
@@ -353,3 +343,1 @@
} else {
query = session.createQuery(deleteSql + field + " = :" + field)
.setParameter(field, value);
final var params = new HashMap<String, Object>();
jonathan коментирира пре 4 година

No use of var in low-level code please

No use of `var` in low-level code please
jonathan reviewed пре 4 година
@@ -364,3 +359,4 @@
final Session session = getHibernateTemplate().getSessionFactory().getCurrentSession();
final String deleteSql = "DELETE FROM " + getEntityClass().getSimpleName() + " WHERE " + whereClause;
final Query query = session.createQuery(deleteSql);
parameters.forEach(query::setParameter);
jonathan коментирира пре 4 година

Just prefix this line with if (!empty(parameters)) so that bulkDeleteWhere(String) can pass a null parameters arg.

Just prefix this line with `if (!empty(parameters))` so that `bulkDeleteWhere(String)` can pass a null `parameters` arg.
jonathan closed this pull request пре 4 година
jonathan deleted branch kris/refactor_bulk_delete_methods пре 4 година

Reviewers

jonathan requested changes пре 4 година
The pull request has been merged as e2783ac80f.
Пријавите се да се прикључе у овом разговору.
No reviewers
Нема лабеле
Нема фазе
No Assignees
2 учесника
Notifications
Due Date

No due date set.

Dependencies

This pull request currently doesn't have any dependencies.

Loading…
Још нема садржаја.