Refactor bulk delete method

Nuova Pull Request

Conversazione 0 Commit 8 File modificati 1

@jonathan please review

jonathan è stato assegnato da kris 4 anni fa

jonathan richieste modifiche 4 anni fa

a couple changes requested

wizard-server/src/main/java/org/cobbzilla/wizard/dao/AbstractCRUDDAO.java

												
			@@ -361,3 +355,3 @@
		
			        return bulkDeleteWhere(condition, params);
		
			    }
		
			    public int bulkDeleteWhere(String whereClause) {

jonathan 4 anni fa ha commentato

We still need the version of bulkDeleteWhere that just takes a String and no parameters Map

wizard-server/src/main/java/org/cobbzilla/wizard/dao/AbstractCRUDDAO.java

jonathan revisionato 4 anni fa

wizard-server/src/main/java/org/cobbzilla/wizard/dao/AbstractCRUDDAO.java

jonathan ha fatto riferimento a questa issue dal commit 4 anni fa

Refactor bulk delete method (#12) Merge branch 'master' into kris/refactor_bulk_delete_methods Allow null as parameters in bulk delete method Use StringBuilder instead of appending Strings Use strict types instead of var Add new method for bulk delete with old signature Do not use SingletonMap so it may appended Set bulkDelete's parameters to be non null Refactor bulkDelete methods Co-authored-by: jonathan <jonathan@noreply.git.bubblev.org> Co-authored-by: Kristijan Mitrovic <kmitrovic@itekako.com> Reviewed-on: https://git.bubblev.org/bubblev/cobbzilla-wizard/pulls/12

jonathan closed this pull request 4 anni fa

jonathan branch kris/refactor_bulk_delete_methods eliminato 4 anni fa

Revisori

jonathan richieste modifiche 4 anni fa

La pull request è stata unita come e2783ac80f.

Effettua l'accesso per partecipare alla conversazione.

jonathan

Nessuna etichetta

Nessuna milestone

jonathan

2 Partecipanti

Notifiche

Data di scadenza

Nessuna data di scadenza impostata.

Dipendenze

Questo problema attualmente non ha alcuna dipendenza.

@@ -353,3 +343,1 @@
         } else {
             query = session.createQuery(deleteSql + field + " = :" + field)
                     .setParameter(field, value);
         final var params = new HashMap<String, Object>();

@@ -364,3 +359,4 @@
         final Session session = getHibernateTemplate().getSessionFactory().getCurrentSession();
         final String deleteSql = "DELETE FROM " + getEntityClass().getSimpleName() + " WHERE " + whereClause;
         final Query query = session.createQuery(deleteSql);
         parameters.forEach(query::setParameter);

#12 Refactor bulk delete method

Revisori