Add support for downloading account data

Konversation 3 Incheckningar 22 Ändrade Filer 6

Det finns inget innehåll än.

jonathan blev tilldelad denna av kris 4 år sedan

Note -- You might also need to make some changes to the ActionPage.vue to properly handle approvals for the account download.

kris ändrade titeln från ~~WIP: (not finished) Add support for downloading account data~~ till Add support for downloading account data 4 år sedan

Note: before updating this lib’s refence in the main bubble repo, please review and merge corresponding PR within that one ( bubblev/bubble#8 ) as there are some dependencies (English labels) there.

jonathan begärda ändringar 4 år sedan

I realized I hadn’t submitted my previous review, sorry.

Overall this looks very good, just a few renaming changes and other minor things requested.

src/_services/user.service.js

jonathan kommenterad 4 år sedan

I would call this requestAccountDownload

kris kommenterad 4 år sedan

That was intentionally as some elements in code have Request as suffix, so I tried to make it different. Any other term to use here, or should I just change it to request? demand?
https://www.google.com/search?client=ubuntu&channel=fs&q=sysnonym+request&ie=utf-8&oe=utf-8

jonathan kommenterad 4 år sedan

Yeah just changed to request. It’s OK if the prefix and suffix are both request, they have different semantics.

src/_store/account.module.js

jonathan kommenterad 4 år sedan

the convention is for the commit methods to be named methodNameRequest, methodNameSuccess and methodNameFailure, so these should be requestAccountDownloadRequest, requestAccountDownloadSuccess and requestAccountDownloadFailure

kris kommenterad 4 år sedan

Yes, that’s the one - request...Request. Do we need another haters will hate like comment here? :)

jonathan kommenterad 4 år sedan

Yeah just changed to request. It’s OK if the prefix and suffix are both request, they have different semantics.

src/account/profile/PolicyPage.vue

@jonathan please check my answers here and confirm what to do...

jonathan refererade till detta ärende från en incheckning 4 år sedan

Add support for downloading account data (#2) Replace loading img src in one new place Merge branch 'master' into kris/download_account # Conflicts: # src/account/profile/PolicyPage.vue Rename require with request Shorthen redirect route definition Properly show request account download error Take just first error in case of a list Reset download messages on page load Reuse same download URI method Show download account file status on page Better indent Use state's new property instead of status' property Beautify JSON before downloading it as file Force download of account data json as file Load account data as JSON on request in background Remove not needed status flag Hide download account button for root and other users Fix error and description line for new account download button Better log line on HTTP 422 error Fix log lines' prefix Remove not needed comma Ass initial support for downloading account data Use proper available errData instead of data Co-authored-by: Kristijan Mitrovic <kmitrovic@itekako.com> Reviewed-on: https://git.bubblev.org/bubblev/bubble-web/pulls/2

jonathan closed this pull request 4 år sedan

jonathan tog bort grenen kris/download_account 4 år sedan

Granskare

jonathan begärda ändringar 4 år sedan

Pull-förfrågan har sammanfogats som 8582fc2745.

Logga in för att delta i denna konversation.

jonathan

Ingen Etikett

Ingen Milsten

jonathan

2 Deltagare

Notiser

Förfallodatum

Inget förfallodatum satt.

Beroenden

Denna pull-förfrågan har för närvarande inga beroenden.

@@ -12,6 +12,7 @@ export const userService = {
     register,
     searchAccounts,
     getMe,
     requireAccountDownload,

@@ -181,1 +183,4 @@
             );
     },
     requireAccountDownload({ commit }, {messages, errors}) {
         commit('requiringAccountDownloadRequest');

@@ -519,6 +530,11 @@
                     errors: this.errors
                 });
             },
             downloadAccount() {

#2 Add support for downloading account data

Granskare