Add support for downloading account data

Discussie 3 Commits 22 Bestanden gewijzigd 6

Er is nog geen inhoud.

jonathan was toegekend door kris 4 jaren geleden

Note -- You might also need to make some changes to the ActionPage.vue to properly handle approvals for the account download.

kris titel aangepast van ~~WIP: (not finished) Add support for downloading account data~~ naar Add support for downloading account data 4 jaren geleden

Note: before updating this lib’s refence in the main bubble repo, please review and merge corresponding PR within that one ( bubblev/bubble#8 ) as there are some dependencies (English labels) there.

jonathan aangevraagde wijzigingen 4 jaren geleden

I realized I hadn’t submitted my previous review, sorry.

Overall this looks very good, just a few renaming changes and other minor things requested.

src/_services/user.service.js

jonathan commented 4 jaren geleden

I would call this requestAccountDownload

kris commented 4 jaren geleden

That was intentionally as some elements in code have Request as suffix, so I tried to make it different. Any other term to use here, or should I just change it to request? demand?
https://www.google.com/search?client=ubuntu&channel=fs&q=sysnonym+request&ie=utf-8&oe=utf-8

jonathan commented 4 jaren geleden

Yeah just changed to request. It’s OK if the prefix and suffix are both request, they have different semantics.

src/_store/account.module.js

jonathan commented 4 jaren geleden

the convention is for the commit methods to be named methodNameRequest, methodNameSuccess and methodNameFailure, so these should be requestAccountDownloadRequest, requestAccountDownloadSuccess and requestAccountDownloadFailure

kris commented 4 jaren geleden

Yes, that’s the one - request...Request. Do we need another haters will hate like comment here? :)

jonathan commented 4 jaren geleden

Yeah just changed to request. It’s OK if the prefix and suffix are both request, they have different semantics.

src/account/profile/PolicyPage.vue

@jonathan please check my answers here and confirm what to do...

jonathan verwees naar dit probleem vanuit commit 4 jaren geleden'

Add support for downloading account data (#2) Replace loading img src in one new place Merge branch 'master' into kris/download_account # Conflicts: # src/account/profile/PolicyPage.vue Rename require with request Shorthen redirect route definition Properly show request account download error Take just first error in case of a list Reset download messages on page load Reuse same download URI method Show download account file status on page Better indent Use state's new property instead of status' property Beautify JSON before downloading it as file Force download of account data json as file Load account data as JSON on request in background Remove not needed status flag Hide download account button for root and other users Fix error and description line for new account download button Better log line on HTTP 422 error Fix log lines' prefix Remove not needed comma Ass initial support for downloading account data Use proper available errData instead of data Co-authored-by: Kristijan Mitrovic <kmitrovic@itekako.com> Reviewed-on: https://git.bubblev.org/bubblev/bubble-web/pulls/2

jonathan heeft deze pull request gesloten 4 jaren geleden

jonathan heeft 4 jaren geleden de branch kris/download_account verwijderd.

Reviewers

jonathan aangevraagde wijzigingen 4 jaren geleden

The pull request has been merged as 8582fc2745.

Log in om deel te nemen aan deze discussie.

jonathan

Geen label

Geen mijlpaal

jonathan

2 deelnemers

Notificaties

Vervaldatum

Geen vervaldatum ingesteld.

Afhankelijkheden

Deze pull-aanvraag heeft momenteel geen afhankelijkheden.

@@ -12,6 +12,7 @@ export const userService = {
     register,
     searchAccounts,
     getMe,
     requireAccountDownload,

@@ -181,1 +183,4 @@
             );
     },
     requireAccountDownload({ commit }, {messages, errors}) {
         commit('requiringAccountDownloadRequest');

@@ -519,6 +530,11 @@
                     errors: this.errors
                 });
             },
             downloadAccount() {

#2 Add support for downloading account data

Reviewers