bubblev
/
bubble-web
8
0
Fork 0
Code Issues 0 Pull Requests 0 Releases 0 Wiki Activity
Labels Milestones
New Pull Request

#12 Fix restore UI

Merged
jonathan merged 7 commits from kris/fix_restore_ui into master 4 years ago
Conversation 0 Commits 7 Files Changed 5
kris commented 4 years ago

@jonathan please review

@jonathan please review
jonathan was assigned by kris 4 years ago
jonathan requested changes 4 years ago
jonathan left a comment

Just one question. Otherwise looks good.

src/_store/account.module.js
@@ -123,1 +124,3 @@
error => commit('restoreFailure', error)
error => {
commit('restoreFailure', error);
systemConfigs.restoringInProgress = false;
jonathan commented 4 years ago

shouldn’t we move the systemConfigs.restoringInProgress = false; statements into the restoreSuccess and restoreFailure mutators?

shouldn't we move the `systemConfigs.restoringInProgress = false;` statements into the `restoreSuccess` and `restoreFailure` mutators?
jonathan closed this pull request 4 years ago
jonathan deleted branch kris/fix_restore_ui 4 years ago

Reviewers

jonathan requested changes 4 years ago
The pull request has been merged as 108d44cb49.
Sign in to join this conversation.
Reviewers
Request review
No reviewers
 jonathan
Labels
Apply labels
Clear labels
No items
No Label
Milestone
Set milestone
Clear milestone
No items
No Milestone
Assignees
Assign users
Clear assignees
No Assignees
 jonathan
2 Participants
Notifications
Due Date

No due date set.

Dependencies

This pull request currently doesn't have any dependencies.

Write Preview
Loading…
Cancel
Save
There is no content yet.
Delete Branch 'kris/fix_restore_ui'

Deleting a branch is permanent. It CANNOT be undone. Continue?

No
Yes