bubblev
/
bubble-web
8
0
複製 0
程式碼 問題管理 0 合併請求 0 版本發佈 0 Wiki Activity
標籤 里程碑
建立合併請求

#12 Fix restore UI

已合併
jonathan 於 4 年之前 將 7 次代碼提交從 kris/fix_restore_ui合併至 master
對話內容 0 程式碼提交 7 Files Changed 5
kris 評論 4 年之前

@jonathan please review

@jonathan please review
jonathan 被kris 4 年之前指派
jonathan requested changes 4 年之前
jonathan left a comment

Just one question. Otherwise looks good.

src/_store/account.module.js
@@ -123,1 +124,3 @@
error => commit('restoreFailure', error)
error => {
commit('restoreFailure', error);
systemConfigs.restoringInProgress = false;
jonathan 評論 4 年之前

shouldn’t we move the systemConfigs.restoringInProgress = false; statements into the restoreSuccess and restoreFailure mutators?

shouldn't we move the `systemConfigs.restoringInProgress = false;` statements into the `restoreSuccess` and `restoreFailure` mutators?
jonathan closed this pull request 4 年之前
jonathan 刪除分支 kris/fix_restore_ui 4 年之前

Reviewers

jonathan requested changes 4 年之前
The pull request has been merged as 108d44cb49.
登入 才能加入這對話。
Reviewers
Request review
No reviewers
 jonathan
標籤
Apply labels
清除已選取標籤
No items
未選擇標籤
里程碑
Set milestone
清除已選取里程碑
No items
未選擇里程碑
Assignees
Assign users
Clear assignees
No Assignees
 jonathan
2 參與者
訊息
Due Date

No due date set.

Dependencies

This pull request currently doesn't have any dependencies.

Write Preview
Loading…
取消
儲存
尚未有任何內容
Delete Branch 'kris/fix_restore_ui'

Deleting a branch is permanent. It CANNOT be undone. Continue?

取消操作
確認操作