#10 login_page_ui

已合併
gegham 4 年之前 將 6 次代碼提交從 login_page_ui合併至 dev
尚未有任何內容
geghammusheghsahakyan98 4 年之前指派
gegham requested changes 4 年之前
@@ -37,3 +34,4 @@
private static final String SEPARATOR = "\\.";
private static final int REQUEST_CODE = 1555;
private static final String CERTIFICATE_NAME = "Bubble Certificate";
private boolean bubbleNameStateFlag = false;
gegham 評論 4 年之前

These 3 variables should be saved in the onSavedInstanceSave bundle, not to be loss in case of state loss.
Make the app portrait only.

These 3 variables should be saved in the onSavedInstanceSave bundle, not to be loss in case of state loss. Make the app portrait only.
ui/src/main/res/layout/activity_login.xml
@@ -8,2 +8,4 @@
tools:context="com.wireguard.android.activity.LoginActivity">


<ImageView
gegham 評論 4 年之前

Keep the dimensions and colors in the corresponding resource files. All across the app XMLs.

Keep the dimensions and colors in the corresponding resource files. All across the app XMLs.
ui/src/main/res/layout/activity_login.xml
@@ -31,2 +81,4 @@
app:layout_constraintVertical_bias="0.424" />

<TextView
android:id="@+id/textView4"
gegham 評論 4 年之前

id names should be logical, textView4 is a bad naming. Change such all across the app XMLs.

id names should be logical, textView4 is a bad naming. Change such all across the app XMLs.
gegham approved these changes 4 年之前
gegham closed this pull request 4 年之前
gegham 刪除分支 login_page_ui 4 年之前

Reviewers

gegham approved these changes 4 年之前
The pull request has been merged as 348619b205.
登入 才能加入這對話。
No reviewers
未選擇標籤
未選擇里程碑
No Assignees
2 參與者
訊息
截止日期

未設定截止日期。

Dependencies

This pull request currently doesn't have any dependencies.

Loading…
尚未有任何內容