bubblev
/
bubble-droid
5
0
Креирај огранак 0
Код Дискусије 0 Захтеви за спајање 0 Издања 0 Вики Activity
Лабеле Фазе
Нови захтев за спајање

#10 login_page_ui

Спојено
gegham споји(ла) 6 комит(е) из login_page_ui у dev пре 4 година
Дискусија 0 Комити 6 Files Changed 25
musheghsahakyan98 коментирира пре 4 година
Још нема садржаја.
gegham was assigned by musheghsahakyan98 пре 4 година
gegham requested changes пре 4 година
ui/src/main/java/com/wireguard/android/activity/LoginActivity.java
@@ -37,3 +34,4 @@
private static final String SEPARATOR = "\\.";
private static final int REQUEST_CODE = 1555;
private static final String CERTIFICATE_NAME = "Bubble Certificate";
private boolean bubbleNameStateFlag = false;
gegham коментирира пре 4 година

These 3 variables should be saved in the onSavedInstanceSave bundle, not to be loss in case of state loss.
Make the app portrait only.

These 3 variables should be saved in the onSavedInstanceSave bundle, not to be loss in case of state loss. Make the app portrait only.
ui/src/main/res/layout/activity_login.xml
@@ -8,2 +8,4 @@
tools:context="com.wireguard.android.activity.LoginActivity">


<ImageView
gegham коментирира пре 4 година

Keep the dimensions and colors in the corresponding resource files. All across the app XMLs.

Keep the dimensions and colors in the corresponding resource files. All across the app XMLs.
ui/src/main/res/layout/activity_login.xml
@@ -31,2 +81,4 @@
app:layout_constraintVertical_bias="0.424" />

<TextView
android:id="@+id/textView4"
gegham коментирира пре 4 година

id names should be logical, textView4 is a bad naming. Change such all across the app XMLs.

id names should be logical, textView4 is a bad naming. Change such all across the app XMLs.
gegham approved these changes пре 4 година
gegham closed this pull request пре 4 година
gegham deleted branch login_page_ui пре 4 година

Reviewers

gegham approved these changes пре 4 година
The pull request has been merged as 348619b205.
Пријавите се да се прикључе у овом разговору.
Reviewers
Request review
No reviewers
 gegham
Лавеле
Apply labels
Уклони лабеле
No items
Нема лабеле
Фаза
Set milestone
Уклони фазу
No items
Нема фазе
Assignees
Assign users
Clear assignees
No Assignees
 gegham
2 учесника
Notifications
Due Date

No due date set.

Dependencies

This pull request currently doesn't have any dependencies.

Write Preview
Loading…
Откажи
Сачувај
Још нема садржаја.
Delete Branch 'login_page_ui'

Deleting a branch is permanent. It CANNOT be undone. Continue?

Не
Да