From e08f31d6747181228a3d3a9780d5a8a76f38fdef Mon Sep 17 00:00:00 2001 From: HelderSepu Date: Fri, 22 Sep 2017 21:37:33 -0400 Subject: [PATCH] Add UnitTests for validateDateTime & validateGuid --- src/core/utils.js | 2 +- test/core/utils.js | 32 ++++++++++++++++++++++++++++++-- 2 files changed, 31 insertions(+), 3 deletions(-) diff --git a/src/core/utils.js b/src/core/utils.js index 338399b3..ac633c34 100644 --- a/src/core/utils.js +++ b/src/core/utils.js @@ -548,7 +548,7 @@ export const validateParam = (param, isXml) => { err = validateGuid(value) } else { err = validateString(value) - } + } if (!err) return errors errors.push(err) } else if ( type === "boolean" ) { diff --git a/test/core/utils.js b/test/core/utils.js index 42103cc1..5b481e8c 100644 --- a/test/core/utils.js +++ b/test/core/utils.js @@ -1,7 +1,7 @@ /* eslint-env mocha */ import expect from "expect" import { fromJS, OrderedMap } from "immutable" -import { mapToList, validateNumber, validateInteger, validateParam, validateFile, fromJSOrdered, getAcceptControllingResponse, createDeepLinkPath, escapeDeepLinkPath } from "core/utils" +import { mapToList, validateDateTime, validateGuid, validateNumber, validateInteger, validateParam, validateFile, fromJSOrdered, getAcceptControllingResponse, createDeepLinkPath, escapeDeepLinkPath } from "core/utils" import win from "core/window" describe("utils", function() { @@ -158,7 +158,7 @@ describe("utils", function() { }) }) - describe("validateFile", function() { + describe("validateFile", function() { let errorMessage = "Value must be a file" it("validates against objects which are instances of 'File'", function() { @@ -171,6 +171,34 @@ describe("utils", function() { }) }) + describe("validateDateTime", function() { + let errorMessage = "Value must be a DateTime" + + it("doesn't return for valid dates", function() { + expect(validateFile(fileObj)).toBeFalsy() + expect(validateFile(null)).toBeFalsy() + }) + + it("returns a message for invalid input'", function() { + expect(validateFile(1)).toEqual(errorMessage) + expect(validateFile("string")).toEqual(errorMessage) + }) + }) + + describe("validateGuid", function() { + let errorMessage = "Value must be a Guid" + + it("doesn't return for valid guid", function() { + expect(validateGuid("8ce4811e-cec5-4a29-891a-15d1917153c1")).toBeFalsy() + expect(validateGuid("{8ce4811e-cec5-4a29-891a-15d1917153c1}")).toBeFalsy() + }) + + it("returns a message for invalid input'", function() { + expect(validateGuid(1)).toEqual(errorMessage) + expect(validateGuid("string")).toEqual(errorMessage) + }) + }) + describe("validateParam", function() { let param = null let result = null