浏览代码

fix: empty ModelExample rendering in a Response w/o `content` (via #5504)

* add failing test

* use falsy notSetValue for oas3SchemaForContentType
bubble
kyle 5 年前
committed by GitHub
父节点
当前提交
39f8ceba55
找不到此签名对应的密钥 GPG 密钥 ID: 4AEE18F83AFDEB23
共有 3 个文件被更改,包括 22 次插入1 次删除
  1. +1
    -1
      src/core/components/response.jsx
  2. +10
    -0
      test/e2e-cypress/static/documents/bugs/5453.yaml
  3. +11
    -0
      test/e2e-cypress/tests/bugs/5453.js

+ 1
- 1
src/core/components/response.jsx 查看文件

@@ -109,7 +109,7 @@ export default class Response extends React.Component {

// Goal: find a schema value for `schema`
if(isOAS3) {
const oas3SchemaForContentType = activeMediaType.get("schema", Map({}))
const oas3SchemaForContentType = activeMediaType.get("schema")

schema = oas3SchemaForContentType ? inferSchema(oas3SchemaForContentType.toJS()) : null
specPathWithPossibleSchema = oas3SchemaForContentType ? List(["content", this.state.responseContentType, "schema"]) : specPath


+ 10
- 0
test/e2e-cypress/static/documents/bugs/5453.yaml 查看文件

@@ -0,0 +1,10 @@
openapi: 3.0.2
info:
title: Response without a schema
version: 1.0.0
paths:
/foo:
get:
responses:
'200':
description: OK

+ 11
- 0
test/e2e-cypress/tests/bugs/5453.js 查看文件

@@ -0,0 +1,11 @@
// http://github.com/swagger-api/swagger-ui/issues/5453

describe("#5453: Responses w/o `content` should not render ModelExample", () => {
it("should not render a ModelExample section", () => {
cy.visit("/?url=/documents/bugs/5453.yaml")
.get("#operations-default-get_foo")
.click()
.get(".responses-inner")
.should("not.have.descendants", ".model-example")
})
})

正在加载...
取消
保存