From f57899c2022b6dcf6d991fe4a1b0c748ca3a56b3 Mon Sep 17 00:00:00 2001 From: Jonathan Cobb Date: Tue, 8 Sep 2020 02:30:06 -0400 Subject: [PATCH] use constants for common empty responses --- .../org/cobbzilla/wizard/resources/ResourceUtil.java | 10 +++++++--- 1 file changed, 7 insertions(+), 3 deletions(-) diff --git a/wizard-server/src/main/java/org/cobbzilla/wizard/resources/ResourceUtil.java b/wizard-server/src/main/java/org/cobbzilla/wizard/resources/ResourceUtil.java index 7d4c3bc..da7a921 100644 --- a/wizard-server/src/main/java/org/cobbzilla/wizard/resources/ResourceUtil.java +++ b/wizard-server/src/main/java/org/cobbzilla/wizard/resources/ResourceUtil.java @@ -37,15 +37,19 @@ import static org.cobbzilla.util.string.StringUtil.UTF8; @Slf4j public class ResourceUtil { - public static Response ok() { return Response.ok().build(); } + public static final Response OK_RESPONSE = Response.ok().build(); + public static final Response OK_EMPTY_OBJECT = Response.ok(Collections.emptyMap()).build(); + public static final Response OK_EMPTY_LIST = Response.ok(Collections.emptyList()).build(); + + public static Response ok() { return OK_RESPONSE; } public static Response ok(Object o) { return Response.ok(o).build(); } public static Response ok_utf8(Object o) { return Response.ok(o).header(CONTENT_ENCODING, UTF8).build(); } - public static Response ok_empty() { return Response.ok(Collections.emptyMap()).build(); } + public static Response ok_empty() { return OK_EMPTY_OBJECT; } - public static Response ok_empty_list() { return Response.ok(Collections.emptyList()).build(); } + public static Response ok_empty_list() { return OK_EMPTY_LIST; } public static Response send(SendableResource resource) { return send(resource.getOut(), resource.getStatus(), resource.getHeaders(), resource.getName(), resource.getContentType(), resource.getContentLength(), resource.getForceDownload());