From e79af2c70ce31672995e708b2adbfa6f5e733f97 Mon Sep 17 00:00:00 2001 From: Jonathan Cobb Date: Sun, 22 Nov 2020 09:49:16 -0500 Subject: [PATCH] add comment --- .../java/org/cobbzilla/wizard/main/MainApiOptionsBase.java | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/wizard-common/src/main/java/org/cobbzilla/wizard/main/MainApiOptionsBase.java b/wizard-common/src/main/java/org/cobbzilla/wizard/main/MainApiOptionsBase.java index 1275617..40fc922 100644 --- a/wizard-common/src/main/java/org/cobbzilla/wizard/main/MainApiOptionsBase.java +++ b/wizard-common/src/main/java/org/cobbzilla/wizard/main/MainApiOptionsBase.java @@ -47,7 +47,12 @@ public abstract class MainApiOptionsBase extends BaseMainOptions { protected String getDefaultApiBaseUri() { return "@API_SERVER"; } @Getter private final String password = initPassword(); - public boolean hasPassword () { return !empty(getPassword()) && password != INVALID_PASSWORD; } + public boolean hasPassword () { + // we really do set password == INVALID_PASSWORD in initPassword if it was not set + // so the != comparison is correct. + //noinspection StringEquality + return !empty(getPassword()) && password != INVALID_PASSWORD; + } public boolean requireAccount() { return true; }