From 6ad35ab2c21b8887f945b65cb224f99d870ab3ed Mon Sep 17 00:00:00 2001 From: Kristijan Mitrovic Date: Wed, 9 Sep 2020 12:48:07 +0200 Subject: [PATCH] Use StringBuilder instead of appending Strings --- .../java/org/cobbzilla/wizard/dao/AbstractCRUDDAO.java | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/wizard-server/src/main/java/org/cobbzilla/wizard/dao/AbstractCRUDDAO.java b/wizard-server/src/main/java/org/cobbzilla/wizard/dao/AbstractCRUDDAO.java index 5859195..b29170b 100644 --- a/wizard-server/src/main/java/org/cobbzilla/wizard/dao/AbstractCRUDDAO.java +++ b/wizard-server/src/main/java/org/cobbzilla/wizard/dao/AbstractCRUDDAO.java @@ -342,17 +342,16 @@ public abstract class AbstractCRUDDAO private int bulkDelete(@NonNull final String field, @Nullable final Object value, final boolean notUuid) { if (value == null) return bulkDeleteWhere(field + " IS NULL"); - - String condition = field + " = :" + field; + final StringBuilder condition = new StringBuilder(field).append(" = :").append(field); final HashMap params = new HashMap<>(); params.put(field, value); if (notUuid) { - condition += " AND uuid != :" + EX_UUID; + condition.append(" AND uuid != :").append(EX_UUID); params.put(EX_UUID, value); } - return bulkDeleteWhere(condition, params); + return bulkDeleteWhere(condition.toString(), params); } public int bulkDeleteWhere(@NonNull final String whereClause) {