#53 Fully forbid network owner deletion

已合併
jonathan 4 年之前 將 7 次代碼提交從 kris/forbid_network_owner_deletion合併至 master

@jonathan please review

Also included fix for Jenkins builds when utils submodules’ links are changed in PRs.

@jonathan please review Also included fix for Jenkins builds when utils submodules' links are changed in PRs.
jonathankris 4 年之前指派
jonathan requested changes 4 年之前
jonathan left a comment

some minor changes requested

@@ -347,2 +349,4 @@
}

@Override
public int bulkDeleteWhere(@NonNull final String whereClause, @NonNull final Map<String, Object> parameters) {
jonathan 評論 4 年之前

Please put @Override on the same line as the method declaration.

Please put `@Override` on the same line as the method declaration.
@@ -349,0 +355,4 @@
}

@Override
public void delete(@Nullable final Collection<Account> accounts) {
jonathan 評論 4 年之前

Please put @Override on the same line as the method declaration.

Please put `@Override` on the same line as the method declaration.
@@ -26,3 +28,3 @@
@Override protected void process() {
try {
final int ct = dataDAO.bulkDeleteWhere("expiration < " + now());
final int ct = dataDAO.bulkDeleteWhere("expiration < " + now(), new HashMap<>());
jonathan 評論 4 年之前

If we keep the original bulkDeleteWhere we don’t need this change.

If we keep the original `bulkDeleteWhere` we don't need this change.
jonathan closed this pull request 4 年之前
jonathan 刪除分支 kris/forbid_network_owner_deletion 4 年之前

Reviewers

jonathan requested changes 4 年之前
The pull request has been merged as 189eda7d46.
登入 才能加入這對話。
No reviewers
未選擇標籤
未選擇里程碑
No Assignees
2 參與者
訊息
Due Date

No due date set.

Dependencies

This pull request currently doesn't have any dependencies.

Loading…
尚未有任何內容