Bladeren bron

Beautify code

pull/14/head
Kristijan Mitrovic 4 jaren geleden
bovenliggende
commit
795150d394
1 gewijzigde bestanden met toevoegingen van 5 en 10 verwijderingen
  1. +5
    -10
      bubble-server/src/main/java/bubble/cloud/dns/godaddy/GoDaddyDnsDriver.java

+ 5
- 10
bubble-server/src/main/java/bubble/cloud/dns/godaddy/GoDaddyDnsDriver.java Bestand weergeven

@@ -15,7 +15,6 @@ import org.cobbzilla.util.http.HttpRequestBean;
import org.cobbzilla.util.http.HttpResponseBean; import org.cobbzilla.util.http.HttpResponseBean;
import org.cobbzilla.util.http.HttpUtil; import org.cobbzilla.util.http.HttpUtil;


import java.io.IOException;
import java.util.*; import java.util.*;
import java.util.concurrent.atomic.AtomicReference; import java.util.concurrent.atomic.AtomicReference;
import java.util.stream.Collectors; import java.util.stream.Collectors;
@@ -142,10 +141,6 @@ public class GoDaddyDnsDriver extends DnsDriverBase<GoDaddyDnsConfig> {
return response.isOk() ? response : die("remove: " + response); return response.isOk() ? response : die("remove: " + response);
}, MAX_GODADDY_RETRIES); }, MAX_GODADDY_RETRIES);
return record; return record;

} catch (IOException e) {
return die("remove: "+e);

} finally { } finally {
if (lock != null && domain.get() != null) unlockDomain(domain.get().getUuid(), lock); if (lock != null && domain.get() != null) unlockDomain(domain.get().getUuid(), lock);
} }
@@ -199,17 +194,17 @@ public class GoDaddyDnsDriver extends DnsDriverBase<GoDaddyDnsConfig> {


private final Map<String, GoDaddyDnsRecord[]> listCache = new ExpirationMap<>(SECONDS.toMillis(10)); private final Map<String, GoDaddyDnsRecord[]> listCache = new ExpirationMap<>(SECONDS.toMillis(10));


public GoDaddyDnsRecord[] listGoDaddyDnsRecords(String url) throws IOException {
final HttpRequestBean request = auth(url);
return listCache.computeIfAbsent(url, k -> {
public GoDaddyDnsRecord[] listGoDaddyDnsRecords(final String goDaddyApiUrl) {
return listCache.computeIfAbsent(goDaddyApiUrl, url -> {
final var request = auth(url);
final HttpResponseBean response; final HttpResponseBean response;
try { try {
response = HttpUtil.getResponse(request); response = HttpUtil.getResponse(request);
} catch (Exception e) { } catch (Exception e) {
log.error("listGoDaddyDnsRecords("+url+"): "+e);
log.error("listGoDaddyDnsRecords(" + url + "): " + e, e);
return GoDaddyDnsRecord.EMPTY_ARRAY; return GoDaddyDnsRecord.EMPTY_ARRAY;
} }
if (!response.isOk()) throw new IllegalStateException("readRecords: "+response);
if (!response.isOk()) throw new IllegalStateException("listGoDaddyDnsRecords: " + response);
return json(response.getEntityString(), GoDaddyDnsRecord[].class); return json(response.getEntityString(), GoDaddyDnsRecord[].class);
}); });
} }


Laden…
Annuleren
Opslaan